Re: [PATCH] input: keypad: lm8323: convert to threaded IRQ

Hi Felipe,

Many thanks for trying to assist me with my problem. To recap,
I'm seeing the keypad lock-up on my N810 using this driver,
when I type quickly.

I tried your patch, and it doesn't fix the issue.  However, I've
read the datasheet for the lm8323 and it looks to me like the
interrupt should be level rather than edge triggered.

The following additional patch makes things work for me.  I
couldn't tell you if it's the correct thing to do but I can no
longer cause the keypad to lock-up by typing too fast.

Regards,

Leigh.

-- 

diff --git a/drivers/input/keyboard/lm8323.c 

b/drivers/input/keyboard/lm8323.c
index 3b21f42..ab0acaf 100644

--- a/drivers/input/keyboard/lm8323.c
+++ b/drivers/input/keyboard/lm8323.c

@@ -734,7 +734,7 @@ static int __devinit lm8323_probe(struct i2c_client 

*client,
  	}

  	err = request_threaded_irq(client->irq, NULL, lm8323_irq,
-			  IRQF_TRIGGER_FALLING, "lm8323", lm);
+			  IRQF_TRIGGER_LOW|IRQF_ONESHOT, "lm8323", lm);
  	if (err) {
  		dev_err(&client->dev, "could not get IRQ %d\n", client->irq);
  		goto fail4;