RE: [PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL
STALE5717d
REVIEWED: 1 (0M)
From: Santosh Shilimkar <hidden>
Date: 2011-02-03 18:39:34
Also in:
linux-arm-kernel
1 review trailer.
-----Original Message----- From: Dave Martin [mailto:dave.martin@linaro.org] Sent: Thursday, February 03, 2011 11:33 PM To: linux-arm-kernel@lists.infradead.org Cc: Dave Martin; Tony Lindgren; Santosh Shilimkar; Jean Pihet; linux-omap@vger.kernel.org; Nicolas Pitre Subject: [PATCH v2 1/5] ARM: omap4: Correct definition of do_wfi() for CONFIG_THUMB2_KERNEL For the Thumb-2 case, the "wfi" mnemonic is used, since in this case the tools will necessarily be new enough to support it. Signed-off-by: Dave Martin <redacted>
I guess, we discussed this patch in your previous post. Acked-by: Santosh Shilimkar <redacted>
quoted hunk ↗ jump to hunk
--- arch/arm/mach-omap2/include/mach/omap4-common.h | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-)diff --git a/arch/arm/mach-omap2/include/mach/omap4-common.hb/arch/arm/mach-omap2/include/mach/omap4-common.h index 5b0270b..68ce058 100644--- a/arch/arm/mach-omap2/include/mach/omap4-common.h +++ b/arch/arm/mach-omap2/include/mach/omap4-common.h@@ -17,8 +17,13 @@ * wfi used in low power code. Directly opcode is used instead * of instruction to avoid mulit-omap build break */ +#ifdef CONFIG_THUMB2_KERNEL +#define do_wfi() \ + __asm__ __volatile__ ("wfi" : : : "memory") +#else #define do_wfi() \ __asm__ __volatile__ (".word 0xe320f003" : : :"memory") +#endif #ifdef CONFIG_CACHE_L2X0 extern void __iomem *l2cache_base; -- 1.7.1