Re: [PATCH] arm: mach-omap2: potential NULL dereference
From: Sergei Shtylyov <hidden>
Date: 2011-01-17 12:32:10
Also in:
kernel-janitors, linux-arm-kernel, lkml
Hello. On 17-01-2011 13:08, Vasiliy Kulikov wrote:
kzalloc() may fail, if so return -ENOMEM.
Signed-off-by: Vasiliy Kulikov<redacted>
[...]
quoted hunk ↗ jump to hunk
diff --git a/arch/arm/mach-omap2/smartreflex.c b/arch/arm/mach-omap2/smartreflex.c index 77ecebf..871bca9 100644 --- a/arch/arm/mach-omap2/smartreflex.c +++ b/arch/arm/mach-omap2/smartreflex.c@@ -260,7 +260,10 @@ static int sr_late_init(struct omap_sr *sr_info) if (sr_class->class_type == SR_CLASS2&& sr_class->notify_flags&& sr_info->irq) { + ret = -ENOMEM; name = kzalloc(SMARTREFLEX_NAME_LEN + 1, GFP_KERNEL); + if (name == NULL) + goto error;
Why not:
if (name == NULL) {
ret = -ENOMEM;
goto error;
}
WBR, Sergei