Thread (4 messages) 4 messages, 4 authors, 2010-12-22
STALE5664d REVIEWED: 1 (0M)

Re: [PATCH] omap: rx51: Remove tvout code that plays with gpio 40

From: Tomi Valkeinen <hidden>
Date: 2010-12-22 10:00:04
Also in: linux-arm-kernel

On Tue, 2010-12-21 at 19:46 +0200, ext Jarkko Nikula wrote:
Commit 60d24ee "Added video data to support tvout on rx51" added code that
tries to assign gpio 40 as OMAP DSS reset_gpio for tvout. This is wrong
since this gpio has nothing to do with OMAP DSS but it is used to control
one switch that selects is the audio jack connected to tvout or audio
circuitry.

This switch is already supported by the RX51 ASoC driver so there is no need
to control it elsewhere. Switch is contolled with ALSA control
'Jack Function' and tvout can be selected with following example:

	amixer -D hw:0 set 'Jack Function' 'TV-OUT'
Looks good. platform_enable/disable and reset_gpio fields should anyway
be removed from the omap_dss_device struct, so this goes into right
direction.

Tony, can you take this patch also, as (I guess) it depends on the
previous rx51 patches from Jarkko?

Acked-by: Tomi Valkeinen <redacted>

 Tomi

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help