Thread (2 messages) 2 messages, 2 authors, 2010-12-22
DORMANTno replies

Re: [PATCH v2] OMAP4: Pandaboard: Fix MMC card detect gpio line

From: Tony Lindgren <tony@atomide.com>
Date: 2010-12-22 01:57:27
Also in: linux-arm-kernel

* Nishanth Menon [off-list ref] [101221 06:14]:
From: Raghuveer Murthy <redacted>

commit bf56f0a6668cd (2.6.37-rc1), from Nishanth Menon attempted
to fix card detection for PandaBoard, unfortunately, the fix missed
to initialize .gpio_cd member of omap2_hsmmc_info. This results
in a default value of '0', which is a valid GPIO line.
On PandaBoard, the side effect of this is that GPIO line 0 controls
the powering TFP410 DVI chip, and without the fix DVI chip is
inadvertently powered.

Tested-by: David Anders <redacted>

Acked-by: Nishanth Menon <nm@ti.com>

Signed-off-by: Kishore Kadiyala <redacted>
Signed-off-by: Raghuveer Murthy <redacted>
---
v2: updated comment description to point out the potential regression.
   it might be nice to have this in .37 rc cycle as the change was
   introduced in .37-rc1, however, the DVI functionality(which is impacted
   as a side effect) is not enabled in .37 rc.
I'll queue this for .38 because of "it never worked earlier either" logic.

Thanks,

Tony
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help