Thread (2 messages) 2 messages, 2 authors, 2021-12-21

Re: [PATCH v2] nvme-cli: Make connect-all matching be case insensitive

From: Daniel Wagner <hidden>
Date: 2021-12-21 13:03:03

On Fri, 17 Dec 2021 14:20:22 -0800, James Smart wrote:
The comparison routine that checks discovery controller traddr with a
discovery log traddr uses a simple strncmp.  For FC, which kicks off
connect-all requests vay systemd, the nvme-fc transport will build
traddr strings with lower case hexadecimal.  Some FC discovery
controllers return traddr strings with upper case hexadecimal. There
was is no rqmt in the NVME-FC spec that it be upper or lower case.
Given the case difference, the connect-all fails the match logic and
doesn't connect to storage.

[...]
Applied, thanks!

[1/1] nvme-cli: Make connect-all matching be case insensitive
      commit: 1264c6323937c4a0342174fdd9be5a66ab1eaf24

Best regards,
-- 
Daniel Wagner [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help