Re: [PATCH] nvme: print out valid arguments when reading from /dev/nvme-fabrics
From: Chaitanya Kulkarni <hidden>
Date: 2021-11-23 08:40:01
From: Chaitanya Kulkarni <hidden>
Date: 2021-11-23 08:40:01
On 11/19/21 00:39, Hannes Reinecke wrote:
Currently applications have a hard time figuring out which nvme-over-fabrics arguments are supported for any given kernel; the ioctl will return an error code on failure, and the application has to guess whether this was due to an invalid argument or due to a connection or controller error. With this patch applications can read a list of supported arguments by simply reading from /dev/nvme-fabrics, allowing them to validate the connection string. Signed-off-by: Hannes Reinecke <hare@suse.de>
this seems useful and will avoid a trip to the source code. Looks good. Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>