On 11/14/21 11:38 AM, Sagi Grimberg wrote:

quoted

Implement a 'dhchap_key' attribute for the nvme_host structure to
support the 'dhchap_secret' connection argument, and a
'dhchap_key' attribute for the nvme_controller structure to support
the 'dhchap_ctrl_secret' connection argument.

Hannes, can you add an example of a json entry to the change log?
Ideally there is some sort of documentation on what is the
format and how to populate the config file?

It is unclear to me how the user is supposed to work with it.
Is there a dump config functionality like we discussed before?

I would rather keep the json functionality separate from this.
Yes, I know that we really need json functionality to make it usable, 
but then the same could be said for other options, too.

And the problem here is that we'll need to coordinate libnvme and 
nvme-cli updates to get the whole thing to build, so I'd rather keep the 
json update separate from this one.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer