Re: [PATCH 10/10] nvme-fabrics: set common attributes during nvmf_init_ctrl
From: James Smart <hidden>
Date: 2021-11-03 00:30:25
From: James Smart <hidden>
Date: 2021-11-03 00:30:25
On 10/20/2021 3:38 AM, Max Gurtovoy wrote:
Move common logic for setting opts, queue_count, sqsize and kato from RDMA/TCP drivers to the fabrics driver. Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com> --- drivers/nvme/host/fabrics.c | 8 +++++++- drivers/nvme/host/fabrics.h | 2 +- drivers/nvme/host/rdma.c | 10 ++-------- drivers/nvme/host/tcp.c | 8 +------- 4 files changed, 11 insertions(+), 17 deletions(-)
Looks reasonable and something for FC to consider. Reviewed-by: James Smart <redacted> -- james