Re: [PATCH] nvme-fabrics: Use shutdown timeout on disconnect
From: Martin Belanger <hidden>
Date: 2021-10-01 13:56:11
From: Daniel Wagner <redacted> Sent: Friday, October 1, 2021 7:11 AM To: Martin Belanger <redacted> Cc: linux-nvme@lists.infradead.org <redacted>; kbusch@kernel.org <kbusch@kernel.org>; axboe@fb.com <axboe@fb.com>; hch@lst.de <hch@lst.de>; sagi@grimberg.me <sagi@grimberg.me>; Martin Belanger <redacted> Subject: Re: [PATCH] nvme-fabrics: Use shutdown timeout on disconnect On Thu, Sep 30, 2021 at 10:56:34AM -0400, Martin Belanger wrote:
quoted hunk ↗ jump to hunk
@@ -244,8 +257,8 @@ int nvmf_reg_write32(struct nvme_ctrl *ctrl, u32 off, u32 val)cmd.prop_set.offset = cpu_to_le32(off); cmd.prop_set.value = cpu_to_le64(val); - ret = __nvme_submit_sync_cmd(ctrl->fabrics_q, &cmd, NULL, NULL, 0, 0, - NVME_QID_ANY, 0, 0); + ret = __nvme_submit_sync_cmd(ctrl->fabrics_q, &cmd, NULL, NULL, 0, + timeout, NVME_QID_ANY, 0, 0);
If I am not mistaken nvmf_connect_io_queue() suffers from the same problem. What I'm trying to fix is the timeout when disconnecting. The disconnect timeout should be short so that we don't get blocked for 1 minute. nvmf_connect_io_queue() is used when establishing a connection, in which case we do want to use the default (longer) timeout. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme