Re: [RFC PATCH 0/3] nvme sq associations
From: Keith Busch <kbusch@kernel.org>
Date: 2021-09-29 01:36:20
On Wed, Sep 29, 2021 at 12:48:49AM +0000, Nikitin, Andrey wrote:
On 9/25/21, 01:38, "Christoph Hellwig" [off-list ref] wrote:quoted
Honestly I'd rather not merge this whole patchset at all. It is a completly frinde feature for a totally misdesigned part of the NVMe spec. Until actual controller in the hands of prosumers support anything like that I'm very reluctant to bloat the driver fast path for it.Thank you for the feedback. While I agree with your remarks regarding feature design in NVMe spec the minimal implementation proposed in this patchset would help resolving the problems outlined int the original post (undesired queue sharing and noisy neighbor).
You still get noisy neighbor with this approach, though: completions from one set can stall the driver from reaping another set's completions that were posted earlier. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme