Thread (19 messages) 19 messages, 6 authors, 2021-09-22

Re: [PATCH 1/2] nvmet: add get_queue_size op for controllers

From: Max Gurtovoy <mgurtovoy@nvidia.com>
Date: 2021-09-22 07:36:02

On 9/22/2021 1:47 AM, Sagi Grimberg wrote:
quoted
diff --git a/drivers/nvme/target/core.c b/drivers/nvme/target/core.c
index b8425fa34300..cd42655d2980 100644
--- a/drivers/nvme/target/core.c
+++ b/drivers/nvme/target/core.c
@@ -1205,7 +1205,10 @@ static void nvmet_init_cap(struct nvmet_ctrl 
*ctrl)
      /* CC.EN timeout in 500msec units: */
      ctrl->cap |= (15ULL << 24);
      /* maximum queue entries supported: */
-    ctrl->cap |= NVMET_QUEUE_SIZE - 1;
+    if (ctrl->ops->get_queue_size)
Maybe call it max_queue_size? it is a maximum supported in essence.
Yes, I can call it get_max_queue_size.



_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help