[PATCH 2/3] nvme/multipath: cosmetic: keep ns nsid locally
From: Anton Eidelman <hidden>
Date: 2021-09-12 01:08:59
Subsystem:
nvm express driver, the rest · Maintainers:
Keith Busch, Jens Axboe, Christoph Hellwig, Sagi Grimberg, Linus Torvalds
Keep the nsid of the current namespace in a local variable. Change the type to unsigned int to make checkpatch happy. Signed-off-by: Anton Eidelman <redacted> --- drivers/nvme/host/multipath.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c
index e8ccdd398f78..a51561d67b93 100644
--- a/drivers/nvme/host/multipath.c
+++ b/drivers/nvme/host/multipath.c@@ -600,16 +600,18 @@ static int nvme_update_ana_state(struct nvme_ctrl *ctrl, down_read(&ctrl->namespaces_rwsem); list_for_each_entry(ns, &ctrl->namespaces, list) { - unsigned nsid; + unsigned int nsid; + unsigned int ns_nsid = ns->head->ns_id; + again: nsid = le32_to_cpu(desc->nsids[n]); - if (ns->head->ns_id < nsid) + if (ns_nsid < nsid) continue; - if (ns->head->ns_id == nsid) + if (ns_nsid == nsid) nvme_update_ns_ana_state(desc, ns); if (++n == nr_nsids) break; - if (ns->head->ns_id > nsid) + if (ns_nsid > nsid) goto again; } up_read(&ctrl->namespaces_rwsem);
--
2.25.1
--
*Lightbits Labs**
*Lead the cloud-native data center
transformation by
delivering *scalable *and *efficient *software
defined storage that is
*easy *to consume.
*This message is sent in confidence for the addressee
only. It
may contain legally privileged information. The contents are not
to be
disclosed to anyone other than the addressee. Unauthorized recipients
are
requested to preserve this confidentiality, advise the sender
immediately of
any error in transmission and delete the email from their
systems.*
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme