Re: [PATCH] nvme: Fix missing error code in nvme_configure_directives()
From: Keith Busch <kbusch@kernel.org>
Date: 2021-09-09 14:47:54
Also in:
lkml
On Thu, Sep 09, 2021 at 05:50:21PM +0800, Jiapeng Chong wrote:
From: chongjiapeng <redacted> The error code is missing in this code scenario, add the error code '-EINVAL' to the return value 'ret'. Eliminate the follow smatch warning: drivers/nvme/host/core.c:786 nvme_configure_directives() warn: missing error code 'ret'.
Nak, the code is correct as-is. Returning a negative error for this harmless condition will result in disabling the controller when we can proceed just fine without directives. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme