On Wed, Aug 25, 2021 at 05:27:10PM +0200, Hannes Reinecke wrote:

quoted

@@ -506,6 +514,7 @@ static int nvme_tcp_process_nvme_cqe(struct nvme_tcp_queue *queue,
  static int nvme_tcp_handle_c2h_data(struct nvme_tcp_queue *queue,
  		struct nvme_tcp_data_pdu *pdu)
  {
+	struct nvme_tcp_request *req;
  	struct request *rq;
  	rq = nvme_find_rq(nvme_tcp_tagset(queue), pdu->command_id);

@@ -534,6 +543,8 @@ static int nvme_tcp_handle_c2h_data(struct nvme_tcp_queue *queue,
  		return -EPROTO;
  	}
+	req = blk_mq_rq_to_pdu(rq);
+	req->status = NVME_SC_SUCCESS;
  	return 0;
  }

Can't you move the initialisation to nvme_tcp_setup_cmd_pdu()?
That'll save to to have to reference the tcp request here ...

Yes, that's a why better place to initialize it. Let me spin a new
version.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme