Thread (3 messages) 3 messages, 3 authors, 2021-06-09

Re: [linux-nvme:nvme-5.14 27/28] drivers/nvme/host/pci.c:539:7: error: implicit declaration of function 'nvme_ctrl_sgl_supported'

From: Chaitanya Kulkarni <hidden>
Date: 2021-06-09 00:14:36
Also in: oe-kbuild-all

On Jun 8, 2021, at 2:30 PM, kernel test robot [off-list ref] wrote:

tree:   git://git.infradead.org/nvme.git nvme-5.14
head:   b0386eb167134d958f1876a1a7e39e113385c516
commit: a854c5eb4e959f0dfc6e1c22b51128ac68bc051c [27/28] nvme-pci: use helper for ctrl sgl check
config: sparc-randconfig-r024-20210608 (attached as .config)
compiler: sparc-linux-gcc (GCC) 9.3.0
reproduce (this is a W=1 build):
       wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
       chmod +x ~/bin/make.cross
       git remote add linux-nvme git://git.infradead.org/nvme.git
       git fetch --no-tags linux-nvme nvme-5.14
       git checkout a854c5eb4e959f0dfc6e1c22b51128ac68bc051c
       # save the attached .config to linux build tree
       COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-9.3.0 make.cross ARCH=sparc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <redacted>

All errors (new ones prefixed by >>):

  drivers/nvme/host/pci.c: In function 'nvme_pci_use_sgls':
quoted
quoted
drivers/nvme/host/pci.c:539:7: error: implicit declaration of function 'nvme_ctrl_sgl_supported' [-Werror=implicit-function-declaration]
    539 |  if (!nvme_ctrl_sgl_supported(&dev->ctrl))
        |       ^~~~~~~~~~~~~~~~~~~~~~~
  cc1: some warnings being treated as errors


vim +/nvme_ctrl_sgl_supported +539 drivers/nvme/host/pci.c

  530    
  531    static inline bool nvme_pci_use_sgls(struct nvme_dev *dev, struct request *req)
  532    {
  533        struct nvme_iod *iod = blk_mq_rq_to_pdu(req);
  534        int nseg = blk_rq_nr_phys_segments(req);
  535        unsigned int avg_seg_size;
  536    
  537        avg_seg_size = DIV_ROUND_UP(blk_rq_payload_bytes(req), nseg);
  538    
quoted
539        if (!nvme_ctrl_sgl_supported(&dev->ctrl))
  540            return false;
  541        if (!iod->nvmeq->qid)
  542            return false;
  543        if (!sgl_threshold || avg_seg_size < sgl_threshold)
  544            return false;
  545        return true;
  546    }
  547    

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org
<.config.gz>

The patches to fix this are already sent.


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help