Thread (7 messages) 7 messages, 2 authors, 2021-05-18

Re: [PATCH 0/4] nvme: nidt and ns-desc related clanup

From: Christoph Hellwig <hch@lst.de>
Date: 2021-05-18 06:49:40

On Mon, May 17, 2021 at 10:05:53PM -0700, Chaitanya Kulkarni wrote:
Hi,

This is a small patch-series tries to minimize the number of the macro
identifiers. 

In the current code we maintain NVME_NIDT_XXX identifire values and the
their length NVME_NIDT_XXX_LEN separately which has 1:1 mapping. This
adds founr extra macros and open coding of such macros in the host and
the target.

With this open coding in future we will have to maintain one extra macro
representing length for each new NIDT identifire that we will add.
I really don't see the point.  You remove one define per type, but
need to create a mapping table entry.  This adds (slightly) more code
and is less obvious.  Do you have any grand plans for which this is
a preparation?

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help