Thread (20 messages) 20 messages, 4 authors, 2021-05-05

Re: [PATCH 0/1] nvme: Export CSTS register via sysfs

From: Christoph Hellwig <hch@lst.de>
Date: 2021-03-19 15:30:39

On Sat, Mar 20, 2021 at 12:22:08AM +0900, Keith Busch wrote:
quoted
I think this is a horrible idea.  Userspace has no business touching
registers even read-only.  MMIO reads can have side effects as well,
intentional or unintentional, and we also open up a whole can of worms
of mismatched memory attributes.
I was thinking the driver wouldn't opt-in if there were read side
effects, but yeah, it's too fragile. I withdraw the suggestion.
I'd still like to understand what values in CSTS Alan cares about.  I
don't think just dumping a register with somewhat awkward encodings
is a good idea.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help