Thread (13 messages) 13 messages, 4 authors, 2021-03-17

Re: [PATCH 2/2] nvme: use driver pdu command for passthrough

From: Sagi Grimberg <sagi@grimberg.me>
Date: 2021-03-16 17:44:28

-blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req,
-		struct nvme_command *cmd)
+blk_status_t nvme_setup_cmd(struct nvme_ns *ns, struct request *req)
  {
+	struct nvme_command *cmd = nvme_req(req)->cmd;
  	blk_status_t ret = BLK_STS_OK;
  
  	if (!(req->rq_flags & RQF_DONTPREP))
  		nvme_clear_nvme_request(req);
  
-	memset(cmd, 0, sizeof(*cmd));
I'm assuming nothing broke with this clearing removed...

Did you happen to run blktests?
- ./check nvme
- nvme_trtype=rdma ./check nvme
- nvme_trtype=tcp ./check nvme

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help