Re: [PATCH 01/10] nvme-discover: lookup existing persistent controllers
From: Hannes Reinecke <hare@suse.de>
Date: 2021-03-16 09:36:47
On 3/15/21 6:38 PM, Sagi Grimberg wrote:
quoted
From: Hannes Reinecke <hare@suse.de> If persistent controller connections are present they should be preferred even if no --device option is given on the commandline. To avoid selecting a temporary non-persistent controller the 'kato' attribute is checked; any controller which does not have this attribute or for which the attribute is '0' will be skipped.Why? You also need a fallback in case kato is not exposed in prior kernels.
The idea was to make the '--device' attribute optional _iff_ the kernel exposes the 'kato' attribute _and_ that attribute is non-zero. Nothing more, nothing less. Apparently the comment was slightly misleading. I never intended to change the current behaviour if the 'kato' attribute is not exposed. Cheers Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme