Thread (8 messages) 8 messages, 5 authors, 2021-03-18

Re: [PATCH 1/1] nvmet: do not allow model_number exceed 40 bytes

From: Chaitanya Kulkarni <hidden>
Date: 2021-03-16 03:41:09

Max,

On 3/15/21 14:50, Sagi Grimberg wrote:
quoted
quoted
According to the NVM specifications, the model number size should be
40 bytes (bytes 63:24 of the Identify Controller data structure).
Therefore, any attempt to store a value into model_number which
exceeds 40 bytes should return an error.

Reviewed-by: Max Gurtovoy <mgurtovoy@nvidia.com>
Signed-off-by: Noam Gottlieb <redacted>
The patch looks good to me, but is this patch not intended for 5.13 ?

Since for 5.13 we have nvmet_subsys_attr_model_store_locked(), this
patch uses nvmet_subsys_attr_model_store().

Is this a fix for 5.12-rc  ?
I think this patch can wait for 5.13 for sure, maybe needs a Fixes
tag to help it get back to stable...
That's what I thought, can you please respin unless there is a reason for
this to be in 5.12 ?





_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help