On 2/24/21 5:25 PM, Christoph Hellwig wrote:

I don't see any regression here, even if the new features sound useful.

Have you ever tried MD RAID on nvme-of?
Without this patch MD RAID will _stop_ I/O until the controller reconnects.
If it does. If it doesn't, the controller gets removed (so after some 
300 seconds), and MD RAID will get an I/O error, finally.
But then you reconnect the failed path, and you end up with a 
_different_ nvme namespace device.
Requiring you to do manual handholding get the MD RAID into shape again.

With this patch it 'just works' without any interaction.

One might argue if that constitutes a regression (as it's been the 
behaviour since day 1), but it certainly is impaired functionality as 
compared to other drivers/subsystems like SCSI.
And we can't have that, can we?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke                Kernel Storage Architect
hare@suse.de                              +49 911 74053 688
SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg
HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme