Re: [PATCH 00/14] nvme: few cleanups and small improvements
From: Keith Busch <kbusch@kernel.org>
Date: 2021-02-24 15:42:54
On Tue, Feb 16, 2021 at 04:10:18PM -0800, Chaitanya Kulkarni wrote:
Hi, This has few cleanups such as variable data type, removing oneliner wrappers for single callers, removing duplicate kfree() and small improvements for NVMeOF Passthru fast path such as likely annotation, removing the extra checks, making function inline for host/core.c. Last couple of patches fixes warning for FC function header documentation.
The two documentation fixes at the end look fine, but much of the rest looks unnecessary.
Chaitanya Kulkarni (14): nvme-core: remove duplicate kfree in init identify nvme-core: don't use switch for only one case use nvme-core: use right type for ARRAY_SIZE check nvme-core: fix the type for shutdown_timeout nvme-core: add helper to init ctrl transport attr nvme-core: add helper to init shutdown timeout nvme-core: add helper to init ctrl subsys quirk nvme-core: move util quirk at the top of the file nvme-core: mark nvme_setup_passsthru() inline nvme-core: remove one liner wrappers for streams nvme-core: use likely in nvme_init_request() nvme-core: don't check nvme_req flags for new req nvme-fc: fix the function documentation comment nvmet-fc: update function documentation drivers/nvme/host/core.c | 333 ++++++++++++++++++++------------------- drivers/nvme/host/fc.c | 2 +- drivers/nvme/target/fc.c | 1 + 3 files changed, 172 insertions(+), 164 deletions(-) -- 2.22.1
_______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme