On Thu, Feb 18, 2021 at 05:29:27PM +0100, Hannes Reinecke wrote:

On 2/18/21 10:46 AM, Martin George wrote:

quoted

Given discovery controllers can now accept integer arguments
for kato, permit the same in build_options().

Signed-off-by: Martin George <redacted>
---
  fabrics.c | 5 ++---
  1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/fabrics.c b/fabrics.c
index 1880a5d..9cfe26a 100644
--- a/fabrics.c
+++ b/fabrics.c

@@ -896,9 +896,8 @@ static int build_options(char *argstr, int max_len, bool discover)
  	    (!discover &&
  	      add_int_argument(&argstr, &max_len, "queue_size",
  				cfg.queue_size, false)) ||
-	    (!discover &&
-	      add_int_argument(&argstr, &max_len, "keep_alive_tmo",
-				cfg.keep_alive_tmo, false)) ||
+	    add_int_argument(&argstr, &max_len, "keep_alive_tmo",
+				cfg.keep_alive_tmo, false) ||
  	    add_int_argument(&argstr, &max_len, "reconnect_delay",
  				cfg.reconnect_delay, false) ||
  	    add_int_argument(&argstr, &max_len, "ctrl_loss_tmo",

Reviewed-by: Hannes Reinecke <hare@suse.de>

Martin, you probably have to resend it via a pull request to the github
repository.

Not necessary, I am totally okay with applying these direct from the
mailing list.

Thanks for the review, patch is already applied!

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme