Re: [PATCH 1/2] nvmet: don't check iosqes,iocqes for discovery controllers
From: Christoph Hellwig <hch@lst.de>
Date: 2021-02-10 10:10:54
On Tue, Feb 09, 2021 at 02:12:34AM -0800, Sagi Grimberg wrote:
+ if (!ctrl->subsys->type == NVME_NQN_DISC &&
I think the normal way to write this would be a !=.
+ (nvmet_cc_iosqes(ctrl->cc) != NVME_NVM_IOSQES ||
+ nvmet_cc_iocqes(ctrl->cc) != NVME_NVM_IOCQES)) {By the spec we'd need to check these are 0, but of course we'd break the existing Linux host. Maybe throw in a comment? _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme