Re: [PATCH] nvme-tcp: Check if request has started before processing it
From: Hannes Reinecke <hare@suse.de>
Date: 2021-02-13 08:48:38
Also in:
lkml
From: Hannes Reinecke <hare@suse.de>
Date: 2021-02-13 08:48:38
Also in:
lkml
On 2/12/21 7:17 PM, Daniel Wagner wrote:
blk_mq_tag_to_rq() will always return a request if the command_id is in the valid range. Check if the request has been started. If we blindly process the request we might double complete a request which can be fatal. Signed-off-by: Daniel Wagner <redacted> --- This patch is against nvme-5.12. There is one blk_mq_tag_to_rq() in nvme_tcp_recv_ddgst() which I didn't update as I am not sure if it's also needed.
I guess it is; this patch is essentially a protection against invalid frames, and as such affects all places. Cheers, Hannes -- Dr. Hannes Reinecke Kernel Storage Architect hare@suse.de +49 911 74053 688 SUSE Software Solutions GmbH, Maxfeldstr. 5, 90409 Nürnberg HRB 36809 (AG Nürnberg), Geschäftsführer: Felix Imendörffer _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme