On Wed, Feb 03, 2021 at 12:22:31PM +0100, Filippo Sironi wrote:

On 2/3/21 12:15 PM, Christoph Hellwig wrote:

quoted

On Wed, Feb 03, 2021 at 12:12:31PM +0100, Filippo Sironi wrote:

quoted

I don't disagree on the first part of your sentence, this is a big
oversight.

But it is not what your commit log suggests.

I can definitely rephrase the commit.

quoted

quoted

On the other hand, those controllers are out there and are in use by a lot
of customers.  We can keep relying on luck, hoping that customers don't run
into troubles or we can merge a few lines of code :)

Your patch does not just quirk a few controllers out there, but all
current and future controllers with an Amazon vendor ID.  We could
probably talk about quirking an existing vendor ID or two as long as
this doesn't happen for future hardware.

I know that the hardware team is working on this but I don't know the
timelines and there are a few upcoming controllers - of which I don't know
the device ids yet - that have the same issue.

To avoid issues, it is easier to apply the quirk to all Amazon NVMe
controllers for now till the new lines of controllers with the fix comes
out.  At that point, we'll be able to restrict the application to the known
bad controllers.

Just set the quirk for the known device id's and append more as needed
(which should hopefully never happen). Sure, your future broken devices
may not work with the first kernel that introduced the quirk, but this
is how the quirks should be documented in the code.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme