Re: [PATCH 2/2] nvme: return -ETIMEDOUT in nvme_submit_sync_cmd()
From: Daniel Wagner <hidden>
Date: 2021-01-27 09:22:49
From: Daniel Wagner <hidden>
Date: 2021-01-27 09:22:49
On Wed, Jan 27, 2021 at 09:06:05AM +0100, Hannes Reinecke wrote:
When a command times out we should be returning -ETIMEDOUT in nvme_submit_sync_cmd(), and not requiring the caller to guess whether a specific NVMe status should be interpreted as a timeout. Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/nvme/host/core.c | 2 ++ drivers/nvme/host/nvme.h | 1 + drivers/nvme/host/rdma.c | 1 + drivers/nvme/host/tcp.c | 1 +
I wonder if we have to do something similar for FC. As far I understand an abort command is issued and the drivers will return the original request with FCPOP_STATE_ABORTED which then will be mapped to NVME_SC_HOST_PATH_ERROR. Can't say if this is good or bad, it's a just different. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme