On 1/20/21 2:03 AM, Max Gurtovoy wrote:

On 1/20/2021 7:09 AM, Chaitanya Kulkarni wrote:

quoted

Max,
On 1/4/21 04:59, Max Gurtovoy wrote:

quoted

All the updates are mentioned in the ratified NVMe 1.4 spec.

Signed-off-by: Max Gurtovoy <mgurtovoy@nvidia.com>
---

I'm not against keeping the header file up to date with the spec,
but should we add the error status into the kernel code even if
we are not using it in the host/target driver ?

I we go with this approach we should remove half of the code inside nvme.h

Yes you are right and I really don't understand the need to add symbols
when they are not used I think I'm also guilty of some :P.

It will be great if someone can clarify the need to add symbols when they
arenot used in the kernel or a use case which needs this sort of update.

quoted

Here we add 24 lines which we have not used at all.

quoted

  include/linux/nvme.h | 24 ++++++++++++++++++++----
  1 file changed, 20 insertions(+), 4 deletions(-)

Regarding the nvme-cli this is much needed a sync since it does
decode all the errors if I'm not wrong.

I can sync it in V2.

_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme