Re: [PATCH] nvme: retrigger ANA log update if group descriptor isn't found
From: Sagi Grimberg <sagi@grimberg.me>
Date: 2021-01-14 03:13:26
quoted hunk ↗ jump to hunk
If ANA is enabled but no ANA group descriptor is found when creating a new namespace the ANA log is most likely out of date, so trigger a re-read. The namespace will be tagged with the NS_ANA_PENDING flag to exclude it from path selection until the ANA log has been re-read. Reported-by: Martin George <redacted> Signed-off-by: Hannes Reinecke <hare@suse.de> --- drivers/nvme/host/multipath.c | 4 ++++ 1 file changed, 4 insertions(+)diff --git a/drivers/nvme/host/multipath.c b/drivers/nvme/host/multipath.c index 74896be40c17..ee4a42dc99a0 100644 --- a/drivers/nvme/host/multipath.c +++ b/drivers/nvme/host/multipath.c@@ -667,6 +667,10 @@ void nvme_mpath_add_disk(struct nvme_ns *ns, struct nvme_id_ns *id) if (desc.state) { /* found the group desc: update */ nvme_update_ns_ana_state(&desc, ns); + } else { + /* group desc not found: trigger a re-read */ + set_bit(NVME_NS_ANA_PENDING, &ns->flags); + queue_work(nvme_wq, &ns->ctrl->ana_work);
btw, I just commented on the original thread, but I do like this one better. Reviewed-by: Sagi Grimberg <sagi@grimberg.me> _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme