Re: [PATCH] nvme-tcp: fix possible data corruption with bio merges
From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-13 18:31:59
From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-13 18:31:59
static inline size_t nvme_tcp_req_cur_length(struct nvme_tcp_request *req)
{
- return min_t(size_t, req->iter.bvec->bv_len - req->iter.iov_offset,
- req->pdu_len - req->pdu_sent);
+ return min_t(size_t, req->iter.count,
+ min_t(size_t, req->iter.bvec->bv_len - req->iter.iov_offset,
+ req->pdu_len - req->pdu_sent));We are not supposed to directly poke into an iov_iter. I suspect this should be something like: return min_t(size_t, iov_iter_single_seg_count(&req->iter), req->pdu_len - req->pdu_sent); _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme