Re: [PATCH 2/3] nvme: check all retry delay times in Identify Controller
From: Minwoo Im <hidden>
Date: 2021-01-12 08:40:55
From: Minwoo Im <hidden>
Date: 2021-01-12 08:40:55
Hello, On 21-01-12 09:08:40, Christoph Hellwig wrote:
On Fri, Jan 08, 2021 at 11:46:58PM +0900, Minwoo Im wrote:quoted
If none of Command Retry Delay Time(CRDT)s are set, then we can simply skip to configure Advanced Command Retry Enable(ACRE). CRDT selection will be made in Completion Queue Entry that controller has responsibility to decide. This patch checks all CRDT[0, 1, and 2] in Identify Controller data structrure instead of checking the first one: CRDT[0].Why?
I thought we should check whether there's at least one CRDT fields are set or not regardless to CRDT number (0, 1, and 2). If CRDT[0] is not set, but CRDT[1] is set, then we can go ahead with CRDT[1] not [0]. Thanks! _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme