-----"Jason Gunthorpe" [off-list ref] wrote: -----

To: "Bernard Metzler" <redacted>
From: "Jason Gunthorpe" <jgg@nvidia.com>
Date: 01/07/2021 08:40PM
Cc: <redacted>, <redacted>,
[off-list ref], "Kamal Heib" [off-list ref], "Yi Zhang"
[off-list ref], "kernel test robot" [off-list ref]
Subject: [EXTERNAL] Re: [PATCH v3] RDMA/siw: Fix handling of
zero-sized Read and Receive Queues.

On Wed, Dec 16, 2020 at 12:00:00PM +0100, Bernard Metzler wrote:

quoted

@@ -933,6 +937,7 @@ int siw_activate_tx(struct siw_qp *qp)
 
 		goto out;
 	}
+no_irq:
 	sqe = sq_get_next(qp);
 	if (sqe) {

Can you please arrange this without the spaghetti goto's? goto is ok
for error unwind at the tail of the function, but should not be used
willy nilly. Move some of this into functions, use normal if
statements, etc.

Okay. I tried to minimize changes but I now think
you are right - it's time to cleanup before it
gets too burlesque.

Will send a v4.

Thanks
Bernard.


_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme