Re: [PATCH v3 1/5] blk-mq: introduce blk_mq_set_request_complete
From: Christoph Hellwig <hch@lst.de>
Date: 2021-01-21 08:42:13
Also in:
linux-block
On Thu, Jan 21, 2021 at 03:03:26PM +0800, Chao Leng wrote:
nvme drivers need to set the state of request to MQ_RQ_COMPLETE when directly complete request in queue_rq. So add blk_mq_set_request_complete.
So I'm not happy with this helper. It should at least: a) be named and documented to only apply for the ->queue_rq faіlure case b) check that the request is in MQ_RQ_IDLE state _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme