Re: [PATCH V9 4/9] nvmet: add ZBD over ZNS backend support
From: "hch@lst.de" <hch@lst.de>
Date: 2021-01-19 06:24:14
Also in:
linux-block
On Tue, Jan 19, 2021 at 04:28:00AM +0000, Damien Le Moal wrote:
What about something like this below to add to Chaitanya series ? This adds the queue limit zone_write_granularity which is set to the physical block size for scsi, and for NVMe/ZNS too since that value is limited to the atomic block size. Lightly tested with both 512e and 4kn SMR drives.
For ZNS it should just be the logic block size, the atomic size is not the right thing use here.
+ if (blk_queue_is_zoned(q)) { + if (limits->zone_write_granularity < limits-quoted
logical_block_size)
Overly long line here, and your mailer wrapped it as a punishment :) That being said I don't think the normal path to set the block size should affect it. Just add the manual call and leave the non-zoned path alone.
+EXPORT_SYMBOL(blk_queue_zone_write_granularity);
EXPORT_SYMBOL_GPL for all zoned stuff. _______________________________________________ Linux-nvme mailing list Linux-nvme@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-nvme