Thread (9 messages) 9 messages, 4 authors, 2021-01-12

Re: [PATCH v2] nvmet-fc: associations list protected by rcu, instead of spinlock_irq where possible.

From: James Smart <hidden>
Date: 2021-01-12 00:43:33
Also in: lkml


On 1/3/2021 10:12 AM, leonid.ravich@dell.com wrote:
From: Leonid Ravich <redacted>

searching assoc_list protected by rcu_read_lock if list not changed inline.
and according to the rcu list rules.

queue array embedded into nvmet_fc_tgt_assoc protected by rcu_read_lock
according to rcu dereference/assign rules.

queue and assoc object freed after grace period by call_rcu.

tgtport lock taken for changing assoc_list.

Reviewed-by: Eldad Zinger <redacted>
Reviewed-by: Elad Grupi <redacted>
Signed-off-by: Leonid Ravich <redacted>
---
1) fixed sytle issus
2) queues array protects by rcu as well

  drivers/nvme/target/fc.c | 81 +++++++++++++++++++++++-------------------------
  1 file changed, 38 insertions(+), 43 deletions(-)
Reviewed-by: James Smart <redacted>

-- james
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help