-----Original Message-----
From: Sagi Grimberg [mailto:sagi at grimberg.me]
Sent: Wednesday, February 22, 2017 1:56 PM
To: Parav Pandit <parav at mellanox.com>; Christoph Hellwig <hch at lst.de>
Cc: linux-nvme at lists.infradead.org; axboe at fb.com; keith.busch at intel.com
Subject: Re: [PATCH] nvme-rdma: Support 2 inline data SGEs for write
commands.

quoted

quoted

quoted

Hi Christoph, Sagi,

quoted

Does this host side patch look fine? Its unrelated to target side

implementation.

I'm still wandering if we want it dynamic according to the target
ioccsz (say 1 per PAGE_SIZE?)

I don't think we are consuming any more resources by increasing to 2SGEs

because it's still aligns to hardware's minimum WQE size of 64B or 128B size.

quoted

Can we add that additional complexity in incremental manner unless 2 SGEs

are less optimal compared to 1?

I'm referring to struct nvme_rdma_request

Yes, I got that now.
That needs to have dynamic allocation for sge array if we want to do based on ioccsz.
Unless we do 4 or 8 or larger SGEs, extra 8 byte pointer to store link to more than one SGE might not be worth enough just for writes.