Thread (28 messages) 28 messages, 6 authors, 2017-01-30
STALE3454d
Revisions (16)
  1. v1 [diff vs current]
  2. v2 [diff vs current]
  3. v3 [diff vs current]
  4. v4 [diff vs current]
  5. v4 [diff vs current]
  6. v4 [diff vs current]
  7. v4 [diff vs current]
  8. v4 current
  9. v4 [diff vs current]
  10. v4 [diff vs current]
  11. v4 [diff vs current]
  12. v4 [diff vs current]
  13. v5 [diff vs current]
  14. v5 [diff vs current]
  15. v5 [diff vs current]
  16. v6 [diff vs current]

[PATCH v4 2/6] block: Add Sed-opal library

From: J Freyensee <hidden>
Date: 2017-01-11 17:47:14

[Snip...]

quoted
+	if(!suspend)
missing whitespace before the (
quoted
+	list_for_each_entry(suspend, &dev->unlk_lst, node) {
+			dev->state = 0;
+			dev->func_data[1] = &suspend->unlk.session;
doube indentation.
Is checkpatch.pl being used before the patches are sent to the list? ?That tool
should have flagged these problems to fix.

While you are at it, it would be good to run the code thru sparse if you
haven't already.

Jay
quoted
?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help