Thread (2 messages) 2 messages, 2 authors, 2016-09-24

[PATCH v3] add u64 number parser

From: torvalds@linux-foundation.org (Linus Torvalds)
Date: 2016-09-24 18:31:16
Also in: linux-scsi, lkml

On Sat, Sep 24, 2016@8:27 AM, James Smart [off-list ref] wrote:
add u64 number parser

Prior patch revised to use kasprintf.
Modified match_number to use kasprintf as well
Why would you do this? It's insane. kasprintf() is not the right thing
at all to use for anything like this. It appears that you want to use
strncpy() or something. Or you could just avoid the extra copy
entirely in 99% of all cases and just use simple_strtol() and check
that the end didn't overflow the substring, which it presumably never
does anyway.

Yes, the stupid code is already disgustingly bad. But let's not make
it *worse*, for chrissake!

               Linus
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help