Thread (3 messages) 3 messages, 2 authors, 2016-08-24
DORMANTno replies

[PATCH] nvme-cli/fabrics: Added hostnqn parameter to connect command

From: Roy Shterman <hidden>
Date: 2016-08-24 06:48:14


On 8/24/2016 2:42 AM, J Freyensee wrote:
On Tue, 2016-08-23@13:05 +0300, Roy Shterman wrote:
quoted
Added user-defined 'hostnqn' to 'connect' command
so users could use the allowed_hosts attribute on the target and
still
connect to target with nvme-cli tool.

usage examples:
	nvme discover -t <TRANSPORT> -a <ADDRESS> -s <SERVICE_ID> -q
<USER-DEFINED_HOSTNQN>
I believe the example needs to be changed from 'discover' to 'connect'
;-)

Jay
That's correct, I will sent a new patch :)
quoted
Signed-off-by: Roy Shterman <roysh at mellanox.com>
---
  fabrics.c |    2 ++
  1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/fabrics.c b/fabrics.c
index 26c4e22..942e987 100644
--- a/fabrics.c
+++ b/fabrics.c
@@ -711,6 +711,8 @@ int connect(const char *desc, int argc, char
**argv)
  			"transport address" },
  		{"trsvcid", 's', "LIST", CFG_STRING, &cfg.trsvcid,
required_argument,
  			"transport service id (e.g. IP port)" },
+		{"hostnqn", 'q', "LIST", CFG_STRING, &cfg.hostnqn,
required_argument,
+			"user-defined hostnqn" },
  		{0},
  	};
  
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help