[PATCH v2 5/5] nvme-rdma: Make sure to shutdown the controller if we can

[PATCH v2 0/5] Some fabrics fixes · sagi@grimberg.me (Sagi Grimberg) · 2016-08-02
[PATCH v2 1/5] nvme-rdma: Fix device removal handling · sagi@grimberg.me (Sagi Grimberg) · 2016-08-02
[PATCH v2 2/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces · sagi@grimberg.me (Sagi Grimberg) · 2016-08-02
[PATCH v2 2/5] nvme-rdma: Remove duplicate call to nvme_remove_namespaces · hch@lst.de (Christoph Hellwig) · 2016-08-03
[PATCH v2 3/5] nvme-rdma: Free the I/O tags when we delete the controller · sagi@grimberg.me (Sagi Grimberg) · 2016-08-02
[PATCH v2 3/5] nvme-rdma: Free the I/O tags when we delete the controller · hch@lst.de (Christoph Hellwig) · 2016-08-03
[PATCH v2 4/5] nvme-loop: Remove duplicate call to nvme_remove_namespaces · sagi@grimberg.me (Sagi Grimberg) · 2016-08-02
[PATCH v2 4/5] nvme-loop: Remove duplicate call to nvme_remove_namespaces · hch@lst.de (Christoph Hellwig) · 2016-08-03
[PATCH v2 5/5] nvme-rdma: Make sure to shutdown the controller if we can · sagi@grimberg.me (Sagi Grimberg) · 2016-08-02
[PATCH v2 5/5] nvme-rdma: Make sure to shutdown the controller if we can · hch@lst.de (Christoph Hellwig) · 2016-08-03

DORMANTno replies

From: hch@lst.de (Christoph Hellwig)
Date: 2016-08-03 09:04:06
Also in: linux-rdma

On Tue, Aug 02, 2016@10:53:39AM +0300, Sagi Grimberg wrote:

Relying on ctrl state in nvme_rdma_shutdown_ctrl is wrong because
it will never be NVME_CTRL_LIVE (delete_ctrl or reset_ctrl invoked it).

Instead, check that the admin queue is connected. Note that it is safe
because we can never see a copmeting thread trying to destroy the admin
queue (reset or delete controller).

Signed-off-by: Sagi Grimberg <sagi at grimberg.me>

Looks fine,

Reviewed-by: Christoph Hellwig <hch at lst.de>

`h`	back out one level
`j`	next message in thread
`k`	previous message in thread
`l`	drill in
`Esc`	close help / fold thread tree
`?`	toggle this help