Thread (3 messages) 3 messages, 3 authors, 2024-08-30

Re: [PATCH nfsd-fixes] nfsd: fix nfsd4_deleg_getattr_conflict in presence of third party lease

From: Chuck Lever <chuck.lever@oracle.com>
Date: 2024-08-29 14:27:17

On Thu, 29 Aug 2024 09:06:28 +1000, NeilBrown wrote:
It is not safe to dereference fl->c.flc_owner without first confirming
fl->fl_lmops is the expected manager.  nfsd4_deleg_getattr_conflict()
tests fl_lmops but largely ignores the result and assumes that flc_owner
is an nfs4_delegation anyway.  This is wrong.

With this patch we restore the "!= &nfsd_lease_mng_ops" case to behave
as it did before the changed mentioned below.  This the same as the
current code, but without any reference to a possible delegation.

[...]
Applied to nfsd-fixes for v6.11-rc, thanks!

[1/1] nfsd: fix nfsd4_deleg_getattr_conflict in presence of third party lease
      commit: 1271e30308ff96cc702bc7ef764fa6546c0541fb

-- 
Chuck Lever
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help