Re: [RESEND PATCH] NFSv4: Always ask for type with READDIR
From: Christoph Hellwig <hch@infradead.org>
Date: 2023-12-06 05:46:17
- FATTR4_WORD0_RDATTR_ERROR, + FATTR4_WORD0_TYPE|FATTR4_WORD0_RDATTR_ERROR,
Missing spaces before and after the |.
quoted hunk ↗ jump to hunk
FATTR4_WORD1_MOUNTED_ON_FILEID, }; uint32_t dircount = readdir->count;@@ -1612,7 +1612,7 @@ static void encode_readdir(struct xdr_stream *xdr, const struct nfs4_readdir_arg unsigned int i; if (readdir->plus) { - attrs[0] |= FATTR4_WORD0_TYPE|FATTR4_WORD0_CHANGE|FATTR4_WORD0_SIZE| + attrs[0] |= FATTR4_WORD0_CHANGE|FATTR4_WORD0_SIZE| FATTR4_WORD0_FSID|FATTR4_WORD0_FILEHANDLE|FATTR4_WORD0_FILEID; attrs[1] |= FATTR4_WORD1_MODE|FATTR4_WORD1_NUMLINKS|FATTR4_WORD1_OWNER| FATTR4_WORD1_OWNER_GROUP|FATTR4_WORD1_RAWDEV|
Here as well, incuding in the existing code. Please add them and stick to the 80 character limit to make it somewhat readable (maybe even split to one flag per line?). Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>