Re: [PATCH 2/2] NFSv4: Allow per-mount tuning of READDIR attrs
From: Benjamin Coddington <hidden>
Date: 2023-10-18 19:18:24
From: Benjamin Coddington <hidden>
Date: 2023-10-18 19:18:24
On 18 Oct 2023, at 14:38, Anna Schumaker wrote:
quoted
It's not yet clear sysadmins will even need a switch like this, so I would go further and say you should hold off on merging anything like it until there is an actual reported need for it. Now, full control over that bitmap is still very neat thing for experimentation by NFS developers. Hiding this behind a Kconfig option would let you merge it but then turn it off in production kernels.Definitely a neat thing to have, but I'm also in favor of hiding it behind a kconfig option to start.
Ah, missed replying to this part in the last message: Ok, if my last message isn't convicing enough, are we talking about something like CONFIG_NFS_EXPERT_SYSFS? I'm worried that trying to make NFS nicer/safer in sysfs just means we're gatekeeping what's already a complex and breakable set of technologies in the one place (sysfs) where we can actually expose some complexity. Ben