Re: [PATCH 1/1] NFSD: add encoding of op_recall flag for write delegation
From: Chuck Lever III <hidden>
Date: 2023-06-07 14:04:04
On Jun 6, 2023, at 7:41 PM, Dai Ngo [off-list ref] wrote: Modified nfsd4_encode_open to encode the op_recall flag properly for OPEN result with write delegation granted.
This appears to have been broken for forever. I can't really nail down a Fixes: commit, so I will add a Cc: stable.
quoted hunk ↗ jump to hunk
Signed-off-by: Dai Ngo <dai.ngo@oracle.com> --- fs/nfsd/nfs4xdr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/fs/nfsd/nfs4xdr.c b/fs/nfsd/nfs4xdr.c index 4590b893dbc8..d7e46b940cce 100644 --- a/fs/nfsd/nfs4xdr.c +++ b/fs/nfsd/nfs4xdr.c@@ -3975,7 +3975,7 @@ nfsd4_encode_open(struct nfsd4_compoundres *resp, __be32 nfserr,p = xdr_reserve_space(xdr, 32); if (!p) return nfserr_resource; - *p++ = cpu_to_be32(0); + *p++ = cpu_to_be32(open->op_recall); /* * TODO: space_limit's in delegations -- 2.9.5
-- Chuck Lever