Hi Chuck,

On Mon, Mar 27, 2023 at 6:28 PM Chuck Lever III [off-list ref] wrote:

quoted

On Mar 27, 2023, at 11:48 AM, Niklas Söderlund [off-list ref] wrote:
This commits seems to have been picked up already, but FWIW it produces
two new warnings with shmobile_defconfig.

WARNING: unmet direct dependencies detected for RPCSEC_GSS_KRB5
 Depends on [n]: NETWORK_FILESYSTEMS [=y] && SUNRPC [=y] && CRYPTO [=n]
 Selected by [y]:
 - NFS_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFS_FS [=y]

WARNING: unmet direct dependencies detected for RPCSEC_GSS_KRB5
 Depends on [n]: NETWORK_FILESYSTEMS [=y] && SUNRPC [=y] && CRYPTO [=n]
 Selected by [y]:
 - NFS_V4 [=y] && NETWORK_FILESYSTEMS [=y] && NFS_FS [=y]

I received a bot warning about this a few days ago, but it did not
appear that it was a priority.

The easiest thing to do would be to revert it, but I'm not clear
on what the impact of this new issue is.

quoted

On 2023-03-08 09:45:09 -0500, Chuck Lever wrote:

quoted

--- a/fs/nfs/Kconfig
+++ b/fs/nfs/Kconfig

@@ -75,7 +75,7 @@ config NFS_V3_ACL

config NFS_V4
     tristate "NFS client support for NFS version 4"
     depends on NFS_FS
-    select SUNRPC_GSS
+    select RPCSEC_GSS_KRB5

RPCSEC_GSS_KRB5 depends on CRYPTO, causing the warning.
However, NFSv4 nfsroot works fine without CRYPTO, so the select can
be conditional.  I have sent a patch to do that:
https://lore.kernel.org/r/42751e1fef65485a5441618bc39735f8b62b3a46.1679988298.git.geert+renesas@glider.be (local)

quoted

quoted

     select KEYS
     help
       This option enables support for version 4 of the NFS protocol

diff --git a/fs/nfsd/Kconfig b/fs/nfsd/Kconfig
index 7c441f2bd444..43b88eaf0673 100644
--- a/fs/nfsd/Kconfig
+++ b/fs/nfsd/Kconfig

@@ -73,7 +73,7 @@ config NFSD_V4
     bool "NFS server support for NFS version 4"
     depends on NFSD && PROC_FS
     select FS_POSIX_ACL
-    select SUNRPC_GSS
+    select RPCSEC_GSS_KRB5
     select CRYPTO

NFSD_V4 selects CRYPTO, so there is no such issue here.

quoted

quoted

     select CRYPTO_MD5
     select CRYPTO_SHA256

Gr{oetje,eeting}s,

                        Geert


--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds