Thread (10 messages) 10 messages, 2 authors, 2023-03-17

Re: [PATCH 1/2] nfsd: don't replace page in rq_pages if it's a continuation of last page

From: Jeff Layton <jlayton@kernel.org>
Date: 2023-03-17 17:24:12

On Fri, 2023-03-17 at 15:04 +0000, Chuck Lever III wrote:
quoted
On Mar 17, 2023, at 10:59 AM, Jeff Layton [off-list ref] wrote:

On Fri, 2023-03-17 at 14:16 +0000, Chuck Lever III wrote:
quoted
In the patch description, would you mention that this case
arises if the READ request is not page-aligned?
Does it though? I'm not sure that page alignment has that much to do
with it. I imagine you can hit this even with aligned I/Os.
Maybe, but no-one has actually seen that. The vast majority of
reports of this problem are with unaligned I/O, which POSIX OS
NFS clients (like the Linux NFS client) usually avoid.

I didn't mean to exclude the possibility of hitting this issue
in other ways, but simply observing a common way it is hit.
An unaligned read will consume an extra page, so maybe it just makes it
more likely to overrun the array in that case?
-- 
Jeff Layton [off-list ref]
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help