Re: [PATCH 0/7] lockd: fix races that can result in stuck filelocks
From: Amir Goldstein <amir73il@gmail.com>
Date: 2023-03-12 15:33:48
On Fri, Mar 3, 2023 at 4:54 PM Chuck Lever III [off-list ref] wrote:
quoted
On Mar 3, 2023, at 7:15 AM, Jeff Layton [off-list ref] wrote: I sent the first patch in this series the other day, but didn't get any responses.We'll have to work out who will take which patches in this set. Once fully reviewed, I can take the set if the client maintainers send Acks for 2-4 and 6-7. nfsd-next for v6.4 is not yet open. I can work on setting that up today.quoted
Since then I've had time to follow up on the client-side part of this problem, which eventually also pointed out yet another bug on the server side. There are also a couple of cleanup patches in here too, and a patch to add some tracepoints that I found useful while diagnosing this. With this set on both client and server, I'm now able to run Yongcheng's test for an hour straight with no stuck locks.
My nfstest_lock test occasionally gets into an endless wait loop for the lock in one of the optests. AFAIK, this started happening after I upgraded my client machine to v5.15.88. Does this seem related to the client bug fixes in this patch set? If so, is this bug a regression? and why are the fixes aimed for v6.4? Thanks, Amir.