Thread (8 messages) 8 messages, 2 authors, 2023-03-15

Re: mountd: Possible bug in next_mnt()

From: Richard Weinberger <richard@nod.at>
Date: 2023-03-12 13:36:10

----- Ursprüngliche Mail -----
On 3/11/23 11:52 AM, Richard Weinberger wrote:
quoted
----- Ursprüngliche Mail -----
quoted
quoted
next_mnt() finds submounts below a given path p.
While investigating into an issue in my crossmount patches for nfs-utils I
noticed
that it does not work when fsid=root, rootdir=/some/path/ and then "/" is being
exported.
In this case next_mnt() is asked to find submounts of "/" but returns none.
I'm not clear as what you are saying... "rootdir=/some/path/" is not an
export option.
Sorry for being imprecise.
rootdir= is an nfs.conf exports option.Point. But I still need the patch in the
correct
format with the Signed-off-by...
Well, the goal of my mail was not sending a ready-to-apply patch.
It was a question. To me next_mnt() looks wrong but I'm not sure whether
the current handling of "/" is desired for some special case I'm not aware of.

I'll happily send a patch after we agree that next_mnt() is wrong.

Thanks,
//richard
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help