Thread (2 messages) 2 messages, 2 authors, 2023-04-05
STALE1166d

[PATCH] [nfs/nfs-utils] rpcdebug: avoid buffer underflow if read() returns 0

From: Zhi Li <hidden>
Date: 2023-03-09 06:21:18
Subsystem: the rest · Maintainer: Linus Torvalds

Fixes: https://bugzilla.redhat.com/show_bug.cgi?id=2176740

Signed-off-by: Zhi Li <redacted>
---
 tools/rpcdebug/rpcdebug.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/rpcdebug/rpcdebug.c b/tools/rpcdebug/rpcdebug.c
index 68206cc5..ec05179e 100644
--- a/tools/rpcdebug/rpcdebug.c
+++ b/tools/rpcdebug/rpcdebug.c
@@ -257,7 +257,7 @@ get_flags(char *module)
 		perror(filename);
 		exit(1);
 	}
-	if ((len = read(sysfd, buffer, sizeof(buffer))) < 0) {
+	if ((len = read(sysfd, buffer, sizeof(buffer))) <= 0) {
 		perror("read");
 		exit(1);
 	}
-- 
2.39.0
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help